fix: resolve clippy warnings and formatting issues for CI

- Fix doc_markdown warnings in WhatsApp channel
- Fix needless_pass_by_value in cron, health, migration, service modules
- Fix match_same_arms in migration.rs
- Fix too_many_lines in skills/mod.rs
- Fix manual_let_else in tools/file_write.rs
- Apply cargo fmt formatting fixes

All 435 tests pass, clippy clean.
This commit is contained in:
argenis de la rosa 2026-02-14 15:36:19 -05:00
parent 4fce8a5004
commit 153d6ff149
12 changed files with 46 additions and 54 deletions

View file

@ -18,10 +18,11 @@ pub struct CronJob {
pub last_status: Option<String>,
}
pub fn handle_command(command: super::CronCommands, config: Config) -> Result<()> {
#[allow(clippy::needless_pass_by_value)]
pub fn handle_command(command: super::CronCommands, config: &Config) -> Result<()> {
match command {
super::CronCommands::List => {
let jobs = list_jobs(&config)?;
let jobs = list_jobs(config)?;
if jobs.is_empty() {
println!("No scheduled tasks yet.");
println!("\nUsage:");
@ -33,8 +34,7 @@ pub fn handle_command(command: super::CronCommands, config: Config) -> Result<()
for job in jobs {
let last_run = job
.last_run
.map(|d| d.to_rfc3339())
.unwrap_or_else(|| "never".into());
.map_or_else(|| "never".into(), |d| d.to_rfc3339());
let last_status = job.last_status.unwrap_or_else(|| "n/a".into());
println!(
"- {} | {} | next={} | last={} ({})\n cmd: {}",
@ -52,14 +52,14 @@ pub fn handle_command(command: super::CronCommands, config: Config) -> Result<()
expression,
command,
} => {
let job = add_job(&config, &expression, &command)?;
let job = add_job(config, &expression, &command)?;
println!("✅ Added cron job {}", job.id);
println!(" Expr: {}", job.expression);
println!(" Next: {}", job.next_run.to_rfc3339());
println!(" Cmd : {}", job.command);
Ok(())
}
super::CronCommands::Remove { id } => remove_job(&config, &id),
super::CronCommands::Remove { id } => remove_job(config, &id),
}
}

View file

@ -66,7 +66,7 @@ async fn execute_job_with_retry(
}
if attempt < retries {
let jitter_ms = (Utc::now().timestamp_subsec_millis() % 250) as u64;
let jitter_ms = u64::from(Utc::now().timestamp_subsec_millis() % 250);
time::sleep(Duration::from_millis(backoff_ms + jitter_ms)).await;
backoff_ms = (backoff_ms.saturating_mul(2)).min(30_000);
}