harald/zeroclaw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

fix(approval): harden CLI approval flow and summaries

Browse source
This commit is contained in:
Chummy 2026-02-17 22:04:34 +08:00
parent ab561baa97
commit bb641d28c2
2 changed files with 54 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/approval/mod.rs
View file

@ -201,20 +201,10 @@ fn summarize_args(args: &serde_json::Value) -> String {
.iter()
.map(|(k, v)| {
let val = match v {
serde_json::Value::String(s) => {
if s.len() > 80 {
format!("{}…", &s[..77])
} else {
s.clone()
}
}
serde_json::Value::String(s) => truncate_for_summary(s, 80),
other => {
let s = other.to_string();
if s.len() > 80 {
format!("{}…", &s[..77])
} else {
s
}
truncate_for_summary(&s, 80)
}
};
format!("{k}: {val}")
@ -224,15 +214,21 @@ fn summarize_args(args: &serde_json::Value) -> String {
}
other => {
let s = other.to_string();
if s.len() > 120 {
format!("{}…", &s[..117])
} else {
s
}
truncate_for_summary(&s, 120)
}
}
}
fn truncate_for_summary(input: &str, max_chars: usize) -> String {
let mut chars = input.chars();
let truncated: String = chars.by_ref().take(max_chars).collect();
if chars.next().is_some() {
format!("{truncated}…")
} else {
input.to_string()
}
}
// ── Tests ────────────────────────────────────────────────────────
#[cfg(test)]
@ -404,6 +400,15 @@ mod tests {
assert!(summary.len() < 200);
}
#[test]
fn summarize_args_unicode_safe_truncation() {
let long_val = "🦀".repeat(120);
let args = serde_json::json!({"content": long_val});
let summary = summarize_args(&args);
assert!(summary.contains("content:"));
assert!(summary.contains('…'));
}
#[test]
fn summarize_args_non_object() {
let args = serde_json::json!("just a string");